Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update translations #18849

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: Update translations #18849

wants to merge 1 commit into from

Conversation

RuffleBuild
Copy link
Collaborator

New Crowdin pull request with translations 🎉

@RuffleBuild RuffleBuild added T-chore Type: Chore (like updating a dependency, it's gotta be done) A-i18n Area: Internationalization & Localization labels Dec 3, 2024
torokati44
torokati44 previously requested changes Dec 3, 2024
View reviewed changes
desktop/assets/texts/es-ES/preferences_dialog.ftl Outdated Show resolved Hide resolved
@torokati44
Copy link
Member

Summoning @sombraguerrero, because I saw that you approved these after "Load3r" suggested them (with one exception, after undoing that translated string key mistake).

At least one of these strings having changed in #18839, and is now essentially reverted. I think it would be great to avoid any sort of back-and-forth between the variants in the future.

@github-actions github-actions bot force-pushed the l10n_crowdin_translations branch from 39c3d22 to a8e1345 Compare December 4, 2024 00:03
@torokati44 torokati44 dismissed their stale review December 4, 2024 00:04

Undid the problematic translation.

@sombraguerrero
Copy link
Contributor

I acknowledge my timing on that one sucked. Just haven't had a to of time lately, sorry.

@torokati44
Copy link
Member

torokati44 commented Dec 4, 2024 •
edited
Loading

Yeah no worries - I mainly wanted confirmation about the rest of the strings, that these are indeed the better ones, and are here to stay. 😊

@github-actions github-actions bot force-pushed the l10n_crowdin_translations branch 3 times, most recently from bcd1646 to e2824ef Compare December 6, 2024 21:07
torokati44
torokati44 reviewed Dec 7, 2024
View reviewed changes
web/packages/core/texts/ja-JP/messages.ftl Outdated
Comment on lines 24 to 26
clipboard-message-copy = { " " } からコピー
clipboard-message-cut = { " " } : 切り取り
clipboard-message-paste = { " " } : 貼り付け
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's strange that these are not consistent...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my mistake, sorry.
I will correct it later.

@github-actions github-actions bot force-pushed the l10n_crowdin_translations branch 7 times, most recently from 230ded4 to b4a0465 Compare December 13, 2024 21:09
@github-actions github-actions bot force-pushed the l10n_crowdin_translations branch from b4a0465 to 1227e44 Compare December 14, 2024 21:07
@github-actions github-actions bot force-pushed the l10n_crowdin_translations branch from 1227e44 to 2663c8c Compare December 15, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@creeper-0910 creeper-0910 creeper-0910 left review comments

@danielhjacobs danielhjacobs danielhjacobs left review comments

@torokati44 torokati44 torokati44 left review comments

Assignees
No one assigned
Labels
A-i18n Area: Internationalization & Localization T-chore Type: Chore (like updating a dependency, it's gotta be done)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RuffleBuild @torokati44 @sombraguerrero @danielhjacobs @creeper-0910