avm1: Don't attempt to serialize MovieClips #4637
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the stack overflow in #4631 (after you change locations after getting the crowbar early on)
Note: if there ever was a special case in FP where it did somehow serialize some contents of MovieClips, this will break saving this.
In particular, I haven't tested custom AS classes deriving from MovieClip, as... I don't really know how :( Feel free to block this if you think this needs to be checked first.