web: Re-enable context menu on mobile, with option to disable #5000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielhjacobs
force-pushed
the
make_mobile_context_menu_only_optionally_hidden
branch
from
e27496d to
631e964
Compare
danielhjacobs
force-pushed
the
make_mobile_context_menu_only_optionally_hidden
branch
from
631e964 to
a109ea5
Compare
danielhjacobs
changed the title
adrian17
approved these changes
Aug 18, 2021
|
For the record, my words from discord:
|
adrian17
force-pushed
the
make_mobile_context_menu_only_optionally_hidden
branch
from
ca68742 to
4cc1f6d
Compare
adrian17
force-pushed
the
make_mobile_context_menu_only_optionally_hidden
branch
from
4cc1f6d to
32aa3c4
Compare
danielhjacobs
deleted the
make_mobile_context_menu_only_optionally_hidden
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4980, while still keeping in mind the intention of #3967. Tested with the helicopter game (#1972). After a quick appearance of the menu, it is simple enough to click "Hide this menu", and then the game functions fine from then on.
Note: There is no way, currently, to re-enable the context menu after disabling it. The one way I could think of was appending a small div with an "Enable context menu" button above a corner of the ruffle player after disabling the context menu, but that would have potentially obscured controls or text or graphics. However, I still think this is better than hiding the context menu altogether on mobile devices, as it is useful (especially the full screen option) more often than not.