-
-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev: have required builds 'run' #5332
Conversation
b47ded8
to
5a61886
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Any idea why there are still the following skipped checks?
Maybe that's because |
No, those are always going to exist. There are two mutually exclusive builds: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still sad this stuff is way more complex than it should be, but I guess that's the way it is :(
Bring in the OR filtering from #5212, but have the required builds "run" (with a blank step).