Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: have required builds 'run' #5332

Merged
merged 3 commits into from
Sep 21, 2021
Merged

Conversation

midgleyc
Copy link
Contributor

Bring in the OR filtering from #5212, but have the required builds "run" (with a blank step).

Copy link
Contributor

@relrelb relrelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@relrelb
Copy link
Contributor

relrelb commented Sep 20, 2021

Any idea why there are still the following skipped checks?

  • Test Rust / Test Rust ${{ matrix.rust_version }} / ${{ matrix.os }}
  • Test Web / Test Node.js ${{ matrix.node_version }} / Rust ${{ matrix.rust_version }} / ${{ matrix.os }}

Maybe that's because master has not been updated yet?

@midgleyc
Copy link
Contributor Author

No, those are always going to exist.

There are two mutually exclusive builds: build and check-required. The one that doesn't run will display the skipped check (with the non-populated matrix versions); the one that runs should display the others.

Copy link
Collaborator

@adrian17 adrian17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still sad this stuff is way more complex than it should be, but I guess that's the way it is :(

@adrian17 adrian17 merged commit 7f09e75 into ruffle-rs:master Sep 21, 2021
@midgleyc midgleyc deleted the fix-ci-again branch September 21, 2021 19:02
@n0samu n0samu mentioned this pull request Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants