core: Print swf version on startup, and warn when we run into avm2 #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It'd be better to grab the AVM version out of the FileAttributes tag, which will appear once as the very first tag in SWF8+. (We'll have to do this anyway to begin switching on AVM2 behavior, and to get other sandbox settings). |
Dinnerbone
force-pushed
the
feature/web_log
branch
from
8474262 to
e43cb51
Compare
|
Clever! Updated to use FileAttributes. I know this wouldn't be the right place to actually read/use FileAttributes, but given the comments in #404 I don't want to blow up "simple warning on avm2 content" into a proper FileAttributes parser. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help with the occasional issue we get about avm2 content.