canvas: Remove BitmapDataStorage and fix lifetime of bitmap data
#7051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove `BitmapDataStorage` as its no longer necessary, and store the bitmap canvas/context in `BitmapData` instead. * Store the `Bitmap` RBGA buffer in the canvas backend. Previously this was thrown away when converted to `ImageData`, but this causes the glitchy pixels mentioned in: ruffle-rs#6975 (comment) `ImageData` does not copy the buffer passed to it, so store it to keep it alive. See: rustwasm/wasm-bindgen#2445
Herschel
force-pushed
the
canvas-bitmap-bug
branch
from
533bd2e to
445562a
Compare
Toad06
approved these changes
May 22, 2022
This was referenced Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BitmapDataStorageas its no longer necessary, and store the bitmap canvas/context inBitmapDatainstead.BitmapRBGA buffer in the canvas backend. Previously this was thrown away when converted toImageData, but this causes the glitchy pixels mentioned in:canvas: Reimplement masking #7026 (comment)
canvas: Use canvas drawing commands for gradients #6975 (comment)
ImageDatadoes not copy the buffer passed to it, so store it to keep it alive. See:web_sys::ImageData Constructor is Not Sound rustwasm/wasm-bindgen#2445