Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

\Elastica\Aggregation\TopHits::setSource() : wrong signature #1012

Closed
mfn opened this issue Dec 19, 2015 · 3 comments
Closed

\Elastica\Aggregation\TopHits::setSource() : wrong signature #1012

mfn opened this issue Dec 19, 2015 · 3 comments

Comments

@mfn
Copy link
Contributor

mfn commented Dec 19, 2015

It's the same issue as #818 ; _source can be set to false in the ES API, but not with this client.

The TopHits documentation doesn't mention it explicitly but refers to Soure Filtering documentat which documents it.
@ewgRa
Copy link
Contributor

ewgRa commented Dec 19, 2015

Do you want to contribute? :)

@mfn
Copy link
Contributor Author

mfn commented Dec 20, 2015

Sorry don't plan at the moment, too busy! When I removed old code in my project I realized I had a workaround for this issue.

@ruflin
Copy link
Owner

ruflin commented Dec 31, 2015

@mfn Thanks for the reporting. I opened #1015 to fix it. Side note here: It is always possible to pass a bool other other params by using setParam directly instead of setSource.

@ruflin ruflin closed this as completed in 01e17ef Dec 31, 2015
ruflin added a commit that referenced this issue Dec 31, 2015
@ruflin
Merge pull request #1015 from ruflin/tophits-source
e24c3a6 
Allow bool in TopHits::setSource. Closes #1012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mfn @ruflin @ewgRa