Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for parent id query missing #1287

Closed
mfn opened this issue Apr 13, 2017 · 2 comments
Closed

Support for parent id query missing #1287

mfn opened this issue Apr 13, 2017 · 2 comments
Labels
enhancement

Comments

@mfn
Copy link
Contributor

mfn commented Apr 13, 2017

Docs: https://www.elastic.co/guide/en/elasticsearch/reference/5.3/query-dsl-parent-id-query.html

AFAICS there's nothing supporting this in Elastica.

E.g. new ParentId(string $type, $id, bool $ignoreUnmapped = false)
@ruflin
Copy link
Owner

ruflin commented Apr 18, 2017

Yes, this query is currently missing. Interested to add is a contribution?

giovannialbero1992 pushed a commit to giovannialbero1992/Elastica that referenced this issue May 15, 2017
Added support to parent id query [ruflin#1287]
b5bee9e
giovannialbero1992 pushed a commit to giovannialbero1992/Elastica that referenced this issue May 15, 2017
Added support to parent id query [ruflin#1287]
b9e5da3
giovannialbero1992 pushed a commit to giovannialbero1992/Elastica that referenced this issue May 16, 2017
Added support to parent id query [ruflin#1287]
0d3f11b
giovannialbero1992 pushed a commit to giovannialbero1992/Elastica that referenced this issue May 16, 2017
Added support to parent id query [ruflin#1287]
cfc1d5b
giovannialbero1992 pushed a commit to giovannialbero1992/Elastica that referenced this issue May 17, 2017
Added support to parent id query [ruflin#1287]
8643d83
giovannialbero1992 pushed a commit to giovannialbero1992/Elastica that referenced this issue May 19, 2017
Added support to parent id query [ruflin#1287]
23f1545
ruflin pushed a commit that referenced this issue May 19, 2017
@giovannialbero1992 @ruflin
Added support to parent id query [#1287] (#1308)
fa694e0
@mfn
Copy link
Contributor Author

mfn commented Jun 7, 2017

Fixed in #1308

Thanks 😄

@mfn mfn closed this as completed Jun 7, 2017
mhernik pushed a commit to mhernik/Elastica that referenced this issue Jul 24, 2017
@giovannialbero1992
Added support to parent id query [ruflin#1287] (ruflin#1308)
2085ce1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mfn @ruflin