Cannot get mapping of alias with ES1.1

[mal]

The real index name now forms part of the mapping response. This is a problem because the current getMapping function uses the name of the Index being queried as the key to look for in the response. An example of this can be seen in Type.php#L301 however I believe the same problem exists in Index.php and possibly in other places.

Example

A real index named "foo".
An alias of that index named "bar".

$c = new Client();
$c->getIndex('foo')->getMapping(); // returns correct mapping
$c->getIndex('bar')->getMapping(); // returns empty array

[ruflin]

Should be fixed with this commit: 0b410cd

[mal]

That looks good for fixing the issue in Index.php but I think (although I've not had a chance to test it) that it will still exist in Type.php#L301.

I'm relatively new to Elastica, so I'm not sure what the result of a Type::getMapping call should be, but if it's intended to be basically the same as the argument passed to Type::setMapping then I think it also needs to drill into the results using the Type's name, maybe something like?

    public function getMapping()
    {
        $path = '_mapping';

        $response = $this->request($path, Request::GET);
        $data = $response->getData();

        $mapping = array_shift($data);
        if (isset($mapping['mappings'][$this->getName()]['properties'])) {
            return $mapping['mappings'][$this->getName()]['properties'];
        }

        return array();
    }

[ruflin]

I assume you are right so I reopened the issue. Can you open a pull request with the above?

[mal]

Happy to do so, but I'm a little confused by the tests; IndexTest::testMapping seems to be testing Type::getMapping, while TypeTest::testGetMappingAlias seems to test Index::getMapping :/

[ruflin]

Hm, good point. Seems like I mixed up some stuff :-( It would be really nice if you could directly clean that up and rename / move the functions to the right place. Sorry about that.

[ruflin]

Will close this one as the pull request is merged. Otherwise, please reopen it.