Type.php: Removed Exception thrown in deleteById() #1317
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An exception was thrown if no data set corresponding to param $id was found (and hence was not deleted). Removed this behavior because it is a very harsh reaction to a more or less uncritical situation because the result is the same: The data requested to be deleted no longer exists.
|
I remember we discussed this in an other PR / Issue recently. Could you link to the issue? Also this requires a CHANGELOG entry as it is a breaking change and probably you have to adjust the tests. |
|
Hi @ruflin! We discussed this enhancement in this issue. I'll have a look at the tests. |
|
Tests seem to work now and I have added a line to CHANGELOG.md. |
ruflin
reviewed
Jun 2, 2017
| @@ -266,27 +266,6 @@ public function testDeleteById() | |||
| $this->assertTrue(true); | |||
| } | |||
|
|
|||
| try { | |||
There was a problem hiding this comment.
Instead of removing the tests, could we add one that it now works as expected?
| @@ -20,7 +20,8 @@ All notable changes to this project will be documented in this file based on the | |||
|
|
|||
| ### Improvements | |||
|
|
|||
| - Added support for `other_bucket` and `other_bucket_key` paramters on `Elastica\Aggregation\Filters` | |||
| - Added support for `other_bucket` and `other_bucket_key` parameters on `Elastica\Aggregation\Filters` | |||
| - Removed NotFoundException thrown in `\Elastica\Type::deleteById` [#565](https://github.com/ruflin/Elastica/issues/565) | |||
There was a problem hiding this comment.
This is actually a breaking change.
|
@tastendruecker Any update on this one? |
|
Implemented in #1732 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An exception was thrown if no data set corresponding to param $id was found (and hence was not deleted). Removed this behavior because it is a very harsh reaction to a more or less uncritical situation because the result is the same: The data requested to be deleted no longer exists. The information wether or not a record set was deleted is supposed to be part of the returned $response.