Remove NumericRange query type #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NumericRange query is deprecated in ElasticSearch since version 0.90.8. Use Query\Range instead of Query\NumericRange. @see https://www.elastic.co/guide/en/elasticsearch/reference/0.90/query-dsl-numeric-range-filter.html
|
Could you please update the CHANGELOG.md file? |
|
Yes, of course. I somehow missed that statement in CONTRIBUTING.md, sorry :) |
ruflin
reviewed
Jul 10, 2017
CHANGELOG.md
Outdated
| @@ -15,7 +15,7 @@ All notable changes to this project will be documented in this file based on the | |||
| ### Improvements | |||
|
|
|||
| ### Deprecated | |||
|
|
|||
| - Removed `Query\NumericRange`, use `Query\Range` instead [#1334](https://github.com/ruflin/Elastica/pull/1334) | |||
There was a problem hiding this comment.
This probably goes more under BC Breaks as we didn't deprecated it but removed it.
|
@metamaker Merged. Thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NumericRange query is deprecated in ElasticSearch since version 0.90.8.
Use Query\Range instead of Query\NumericRange.
@see https://www.elastic.co/guide/en/elasticsearch/reference/0.90/query-dsl-numeric-range-filter.html