-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ES6 use strict type on boolean (true|false) #1347
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,15 +16,15 @@ class BoostingTest extends BaseTest | |
['name' => 'Vital Match', 'price' => 2.1], | ||
['name' => 'Mercury Vital', 'price' => 7.5], | ||
['name' => 'Fist Mercury', 'price' => 3.8], | ||
['name' => 'Lama Vital 2nd', 'price' => 3.2], | ||
['name' => 'Lama Vital 2nd', 'price' => 1.2], | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why did this change? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I was testing also the BoostingTest.php, and I forget to remove it during the creation of the PR. in the next PR I will update it. |
||
]; | ||
|
||
protected function _getTestIndex() | ||
{ | ||
$index = $this->_createIndex(); | ||
$type = $index->getType('test'); | ||
$type->setMapping([ | ||
'name' => ['type' => 'text', 'index' => 'analyzed'], | ||
'name' => ['type' => 'text', 'index' => 'true'], | ||
'price' => ['type' => 'float'], | ||
]); | ||
$docs = []; | ||
|
@@ -68,7 +68,7 @@ public function testToArray() | |
*/ | ||
public function testNegativeBoost() | ||
{ | ||
$this->markTestSkipped('ES6 update: in mapping index accepts only strict boolean values (true|false) : https://www.elastic.co/guide/en/elasticsearch/reference/6.0/mapping-index.html'); | ||
$this->markTestSkipped('ES6 update: it looks like that boosting changes in ES6.0. did not find at the moment some docs on it. Results in 5.0 and 6.0 are differents.'); | ||
|
||
$keyword = 'vital'; | ||
$negativeKeyword = 'mercury'; | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,8 +18,6 @@ class MoreLikeThisTest extends BaseTest | |
*/ | ||
public function testSearch() | ||
{ | ||
$this->markTestSkipped('ES6 update: in mapping index accepts only strict boolean values (true|false) : https://www.elastic.co/guide/en/elasticsearch/reference/6.0/mapping-index.html'); | ||
|
||
$client = $this->_getClient(); | ||
$index = new Index($client, 'test'); | ||
$index->create([], true); | ||
|
@@ -28,8 +26,8 @@ public function testSearch() | |
|
||
$type = new Type($index, 'helloworldmlt'); | ||
$mapping = new Mapping($type, [ | ||
'email' => ['store' => 'true', 'type' => 'text', 'index' => 'analyzed'], | ||
'content' => ['store' => 'true', 'type' => 'text', 'index' => 'analyzed'], | ||
'email' => ['store' => 'true', 'type' => 'text', 'index' => 'true'], | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We could probably now use There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. dunno why :) revert in next PR, sorry. |
||
'content' => ['store' => 'true', 'type' => 'text', 'index' => 'true'], | ||
]); | ||
|
||
$mapping->setSource(['enabled' => false]); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also link to the PR number. I'm aware this is normally tricky before opening the PR because it is not known yet :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok I'll update it in the next PR