Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use deprecated inline field #1497

Merged
merged 1 commit into from
May 25, 2018
Merged

Don't use deprecated inline field #1497

merged 1 commit into from
May 25, 2018

Conversation

andrejbaran
Copy link
Contributor

@andrejbaran andrejbaran commented May 24, 2018 •
edited
Loading

Hey there,

this changes script to use source field instead of deprecated inline.

Fixes #1416

@ruflin
Copy link
Owner

ruflin commented May 24, 2018

Thanks for the fix. Code LGTM. Could you add a line to the changelog?

@andrejbaran
Copy link
Contributor Author

andrejbaran commented May 24, 2018 •
edited
Loading

Hey @ruflin, sure, should it go into Bugfixes or Deprecated or Improvements ?

@andrejbaran
Don't use deprecated inline field
11c5506 
`inline` field was deprecated in Elasticsearch 5.6
@andrejbaran
Copy link
Contributor Author

I have put it under Improvements since that imho fits most :)

@ruflin ruflin merged commit 1b098c3 into ruflin:master May 25, 2018
@ruflin
Copy link
Owner

ruflin commented May 25, 2018

@andrejbaran Thanks, LGTM.

@s7anley s7anley deleted the fix/deprecated-inline branch May 27, 2018 17:40
@andrejbaran
Copy link
Contributor Author

Thanks @ruflin just out of curiosity do you have any ETA on a new release?

@ruflin
Copy link
Owner

ruflin commented May 29, 2018

Now that I got 2 requests in 1 day, I should probably do one now. Will try to find some time today.

@ruflin
Copy link
Owner

ruflin commented May 29, 2018

Here you go: http://elastica.io/2018/05/29/release-6-dot-0-2/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrejbaran @ruflin