GeoPolygon - Fix wrong property passed to \count() #1696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Change makes sense to me. Could you add a changelog entry? And if possible, add a functional test? We should have had this in the first place to detect this problem :-( |
deguif
force-pushed
the
fix-geo-polygon-count
branch
from
61135e5
to
8db8dfa
Compare
deguif
force-pushed
the
fix-geo-polygon-count
branch
from
8db8dfa
to
e47630f
Compare
|
@ruflin I added test and changelog entry. |
|
@deguif Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.