Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PHP-cs-fixer settings and fix errors #1760

Merged
merged 1 commit into from
Feb 17, 2020

Conversation

thePanz
Copy link
Collaborator

@thePanz thePanz commented Feb 13, 2020

This is a first step towards the PSR-12
No additional changes have been made apart from running the make fix-phpcs command

@thePanz thePanz requested a review from ruflin February 13, 2020 18:08
@thePanz thePanz force-pushed the php-cs-fixer-cleanups branch 4 times, most recently from 551df2f to 2d42904 Compare February 14, 2020 09:09
Copy link
Owner

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I assume all the reordering did not change anything in the code?
  • Did this all happen by the cs-fixer?

src/Aggregation/BucketScript.php Show resolved Hide resolved
@thePanz thePanz merged commit 98b2f9d into ruflin:master Feb 17, 2020
@thePanz thePanz deleted the php-cs-fixer-cleanups branch February 17, 2020 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants