uncommented version in _params on updateDocument() to support Elatica…

[consolari]

… 7.9.1

The version parameter is removed from elasticsearch, tested on Elasticsearch 7.9.1

[deluxetom]

running into issues upgrading to 7.0 because of this

[deguif]

That was deprecated in https://www.elastic.co/guide/en/elasticsearch/reference/6.8/docs-update.html in 6.7.0 as stated by the documentation.
if_seq_no and if_primary_term replaced it.

[ruflin]

Linking #1797 for reference.

[ruflin]

@consolari Thanks for the change. Even though for some 7.x users this might be a breaking change, we should move forward with it as it was removed already in 6.x. Could you add a changelog entry and also reference the page @deguif linked there with some details.

@deguif I wonder if we should directly add the two params you mentioned.

[deluxetom]

@ruflin @deguif since we didnt have any updates, I created a new PR #1803

[deguif]

Nice @thomaspicquet

@ruflin: I wonder if we should directly add the two params you mentioned.

Do you mean adding specific setters as it was done for version and version_type?

By the way version_type should probably be removed too?

[deluxetom]

Nice @thomaspicquet

@ruflin: I wonder if we should directly add the two params you mentioned.

Do you mean adding specific setters as it was done for version and version_type?

By the way version_type should probably be removed too?

I removed version_type and added the setters/getters for the 2 new params #1803

[ruflin]

@thomaspicquet I guess we can close this PR as yours will solve this one?

[deluxetom]

@thomaspicquet I guess we can close this PR as yours will solve this one?

we can, my PR does fix this issue

[ruflin]

Closing in favor of #1803