-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for pools using DSN #1808
Conversation
Thanks for the addition. I'm always a bit on the fence about adding more external dependency at the same time, get rid of code to maintain is great. My initial reaction was that this might remove quite a bit of code on our end up it seems it is not the case. What else does the DSN lib to add as features to Elastica besides multi hosts or are we just missing multi hosts? Do you know when 2.0 is planned to be shipped? |
Not much. The usual. =)
True. I wanted to keep BC. Ideally I would remove the
I plan to release it as soon we are happy here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha, I missed the most important bit that you are the owner of the lib 🤦♂️ That simplifies things of course as you are in control of it and the release.
I'm good with moving forward here. This PR would also need a changelog entry.
I've released 2.0, PR is ready for review. |
@Nyholm Just wanted to merge this but unfortunately there is now a conflict with master :-( Could you rebased / merge in master? Sorry for the delay on my end which probably caused this. |
No worries. PR is rebased. Tests should pass. |
@Nyholm Thanks for the contribution! |
Wohoo. Thank you for merging |
I was about to update https://github.com/Happyr/elastica-dsn which basically adds DSN support to 6.x. But then I saw that 7.x will have support for DNS but not for multiple hosts.
Im sorry that I introduce a new dependency like this for such a small feature. I do need this feature in my app and I really wanted to try out nyholm/dsn:2.0 before I tag a stable release.
This will support any crazy DSN you may think of. See the full specification here: https://github.com/nyholm/dsn
Let me know what you think.
The PR is in draft as it should not be merged before nyholm/dsn:2.0 is released.