Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow guzzlehttp/guzzle 7.2 version #1816

Merged
merged 2 commits into from
Oct 26, 2020
Merged

Conversation

deguif
Copy link
Collaborator

@deguif deguif commented Oct 20, 2020

Support guzzlehttp/guzzle:7.2 as that's where PHP 8.0 support was added.
It requires some work:

@ruflin
Copy link
Owner

ruflin commented Oct 21, 2020

Will your other guzzle PR fix the current CI issues?

@deguif
Copy link
Collaborator Author

deguif commented Oct 21, 2020

Yes I will make PRs to fix the issues raised here and rebase this one once they get merged.
#1817 is one of them.
There is a second I will have to do as ConnectException inherits now TransferException instead of RequestException, and some tests are relying on RequestException to do some assertions.

Copy link
Owner

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM as soon as CI passes. Probably worth to add a cahngelog entry.

@deguif deguif merged commit db7e4c3 into ruflin:master Oct 26, 2020
@deguif deguif deleted the update-guzzle branch October 26, 2020 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants