Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "keyed" behavior to some aggregations #1876

Merged
merged 1 commit into from
Nov 25, 2020
Merged

Add "keyed" behavior to some aggregations #1876

merged 1 commit into from
Nov 25, 2020

Conversation

romainneutron
Copy link
Contributor

No description provided.

deguif
deguif approved these changes Nov 23, 2020
View reviewed changes
Copy link
Collaborator

@deguif deguif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big 👍 for using trait.

src/Aggregation/Range.php Show resolved Hide resolved
src/Aggregation/PercentilesBucket.php Show resolved Hide resolved
deguif
deguif approved these changes Nov 24, 2020
View reviewed changes
Copy link
Collaborator

@deguif deguif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm waiting another review from @ruflin or @thePanz before merging it to confirm we can live with these BC breaks.

CHANGELOG.md Outdated Show resolved Hide resolved
@deguif deguif mentioned this pull request Nov 24, 2020
Merged
@romainneutron
Copy link
Contributor Author

PR updated comments addressed

ruflin
ruflin reviewed Nov 25, 2020
View reviewed changes
Copy link
Owner

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except the changelog. Seems we also got rid of the breaking changes?

CHANGELOG.md Show resolved Hide resolved
@deguif
Copy link
Collaborator

deguif commented Nov 25, 2020

@ruflin BC break is still there, see #1876 (comment)
It was added to BC break section in changelog.

ruflin
ruflin approved these changes Nov 25, 2020
View reviewed changes
Copy link
Owner

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this BC change.

@deguif deguif merged commit 7da034d into ruflin:master Nov 25, 2020
@deguif
Copy link
Collaborator

deguif commented Nov 25, 2020

Thanks @romainneutron

@romainneutron romainneutron deleted the add-keyed branch November 25, 2020 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

@deguif deguif deguif approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@romainneutron @deguif @ruflin