Use strict option for in_array() function #1929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deguif
commented
Mar 18, 2021
| * @return bool True if index exists | ||
| */ | ||
| public function indexExists($name) | ||
| public function indexExists(string $name) |
There was a problem hiding this comment.
It should not be a BC break as since PHP 7.2 and the parameter type widening feature (https://wiki.php.net/rfc/parameter-no-type-variance) a subclass is allowed to widen the type, so that shouldn't break existing code overriding this method.
ruflin
approved these changes
Mar 22, 2021
You're right, I'll add a changelog. |
deguif
force-pushed
the
use-strict-in_array
branch
from
535418f
to
0f251b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.