Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests host refactoring #846

Merged
merged 21 commits into from
May 16, 2015
Merged

Tests host refactoring #846

merged 21 commits into from
May 16, 2015

Conversation

ruflin
Copy link
Owner

@ruflin ruflin commented May 16, 2015

Make the hostname in the tests dynamic to not require elasticsearch to run on localhost. This is in preparation for also test separations (unit, integration, ...) to make the tests run faster.

@im-denisenko FYI

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling b2456bc on tests-host-refactoring into * on master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 215cd5b on tests-host-refactoring into * on master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 215cd5b on tests-host-refactoring into * on master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling ffe24b1 on tests-host-refactoring into * on master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 628d1d7 on tests-host-refactoring into * on master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 798ee48 on tests-host-refactoring into * on master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 0a22982 on tests-host-refactoring into * on master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling fab4b57 on tests-host-refactoring into * on master*.

@im-denisenko
Copy link
Contributor

@ruflin lgtm.

However, I don't get how it's related to test groups.
I partially implement this separation, based on master, and it's already works fine.

@ruflin
Copy link
Owner Author

ruflin commented May 16, 2015

  • There will probably some conflicts as your changes will touch all the tests
  • The test which use a client, are normally the functional tests.

Unfortunately my builds are not green yet.

@im-denisenko
Copy link
Contributor

There will probably some conflicts as your changes will touch all the tests

I tried to merge this branch, only three files will be unmerged.

The test which use a client, are normally the functional tests.

Yep, but not necessary. Instantiate client !== make request.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 575a282 on tests-host-refactoring into * on master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 024993d on tests-host-refactoring into * on master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling fd95dd2 on tests-host-refactoring into * on master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling c556343 on tests-host-refactoring into * on master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 260a881 on tests-host-refactoring into * on master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 4fecfda on tests-host-refactoring into * on master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 6eeca7f on tests-host-refactoring into * on master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 6eeca7f on tests-host-refactoring into * on master*.

ruflin added a commit that referenced this pull request May 16, 2015
@ruflin ruflin merged commit b703aa6 into master May 16, 2015
@ruflin ruflin deleted the tests-host-refactoring branch May 17, 2015 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants