Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StrategyFactory should check predefined strategies first. #877

Merged
merged 2 commits into from
Jun 15, 2015
Merged

StrategyFactory should check predefined strategies first. #877

merged 2 commits into from
Jun 15, 2015

Conversation

im-denisenko
Copy link
Contributor

Closes #721, #730.

  • Changed order of the class_exists methods.
  • Changed exception message.
  • Updated StrategyFactory::create to be more readable.

ruflin added a commit that referenced this pull request Jun 15, 2015
@ruflin
Merge pull request #877 from im-denisenko/strategy-autoload
97b9c66 
StrategyFactory should check predefined strategies first.
@ruflin ruflin merged commit 97b9c66 into ruflin:master Jun 15, 2015
@ruflin
Copy link
Owner

ruflin commented Jun 15, 2015

I had to rerun the build as PHP 7 and HHVM failed. But now everything is green.

@im-denisenko im-denisenko mentioned this pull request Jun 15, 2015
Closed
@im-denisenko im-denisenko deleted the strategy-autoload branch June 15, 2015 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@im-denisenko @ruflin