fix: fix wrong word choice #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We aim for workarounds. :)
tdulcet
approved these changes
May 15, 2021
There was a problem hiding this comment.
It does not currently have any website-specific “workarounds or fallbacks” and I believe they should be avoided if at all possible. Otherwise you end up with a nightmare like the Auto Text Expander, which has separate code for each supported website.
|
Yeah currently not, but I fear this will be the only way for some websites. I’m thinking of #4 specifically, so if we need to disable it on Twitter then that’s better than breaking Twitter… That said we can remove this sentence if we really don’t do that anymore then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We aim for workarounds. :)