forked from halo-dev/halo
-
Notifications
You must be signed in to change notification settings - Fork 38
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Simplify halo plugin manager (halo-dev#5251)
#### What type of PR is this? /kind improvement /area core /area plugin /milestone 2.12.x #### What this PR does / why we need it: This PR mainly simplifies halo plugin manager. Before this, - we have too many repeat code from super class, which is uncessary - we maintain plugin application context in ExtensionComponentsFinder, which is uncessary and is hard to manage - we fire halo plugin event in halo plugin manager, which is complicated and leads to too many repeat code This PR does: - refactor halo plugin manager - wrap base plugin with spring plugin which contains application context - remove ExtensionComponentsFinder - bridge halo plugin event and spring plugin event - wait extensions fully deleted when stopping Meanwhile, this PR will supersede PR <halo-dev#5236>. #### Which issue(s) this PR fixes: Fixes halo-dev#5226 #### Special notes for your reviewer: Test installing, enabing, disabling, upgrading, reloading and deleting plugins. #### Does this PR introduce a user-facing change? ```release-note None ```
- Loading branch information
Showing
53 changed files
with
1,278 additions
and
1,894 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 changes: 0 additions & 52 deletions
52
application/src/main/java/run/halo/app/plugin/BasePluginFactory.java
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.