Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for default wallet functions in multiwallet environment #117

Merged
merged 1 commit into from
Jul 21, 2022

Conversation

wleev
Copy link
Contributor

@wleev wleev commented Apr 7, 2020

As is the library can not access the default wallet when multiple wallets are loaded. It keeps using the URL format: host:port/ as RPC endpoint when it should be using host:port/wallet.

This solution adds a parameter so that the host:port/wallet URL will always be used, since this will work regardless of whether multiple wallets are loaded or not.

The expected failing test showcases this, but you can also verify this with bitcoin-cli like so ( assuming you start from a state where not other wallets are loaded ):
./bitcoin-cli -rpcuser=testuser -rpcpassword=testpassword -regtest getbalance
./bitcoin-cli -rpcuser=testuser -rpcpassword=testpassword -regtest loadwallet anotherWallet
./bitcoin-cli -rpcuser=testuser -rpcpassword=testpassword -regtest getbalance

After loading a new wallet the getbalance call will fail and should be changed to:
./bitcoin-cli -rpcwallet -rpcuser=testuser -rpcpassword=testpassword -regtest getbalance
Which is the same as adding /wallet to the RPC endpoint.

@pedrobranco
Copy link
Collaborator

Thanks for the fix. I've replaced the variable with a more explicit name allowDefaultWallet and fixed the approach. Please amend the commit @wleev.

test/multi_wallet_test.js Outdated Show resolved Hide resolved
@pedrobranco pedrobranco merged commit b6bbb75 into ruimarinho:master Jul 21, 2022
@0x107D
Copy link

0x107D commented Feb 20, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants