Added support for default wallet functions in multiwallet environment #117
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As is the library can not access the default wallet when multiple wallets are loaded. It keeps using the URL format:
host:port/
as RPC endpoint when it should be usinghost:port/wallet
.This solution adds a parameter so that the
host:port/wallet
URL will always be used, since this will work regardless of whether multiple wallets are loaded or not.The expected failing test showcases this, but you can also verify this with
bitcoin-cli
like so ( assuming you start from a state where not other wallets are loaded ):./bitcoin-cli -rpcuser=testuser -rpcpassword=testpassword -regtest getbalance
./bitcoin-cli -rpcuser=testuser -rpcpassword=testpassword -regtest loadwallet anotherWallet
./bitcoin-cli -rpcuser=testuser -rpcpassword=testpassword -regtest getbalance
After loading a new wallet the
getbalance
call will fail and should be changed to:./bitcoin-cli -rpcwallet -rpcuser=testuser -rpcpassword=testpassword -regtest getbalance
Which is the same as adding
/wallet
to the RPC endpoint.