Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OpenMP Travis Build Error #114

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix OpenMP Travis Build Error #114

wants to merge 1 commit into from

Conversation

VincentS
Copy link
Contributor

This should hopefully fix the OpenMP Travis build error.

@VincentS
Fixed hopefully Travis build error
7c3b787 
Signed-off-by: Vincent Schwarzer <vincent.schwarzer@yahoo.de>
@VincentS VincentS changed the title Fixed hopefully Travis build error Fix OpenMP Travis Build Error Jun 30, 2016
@VincentS VincentS mentioned this pull request Jun 30, 2016
Open
@VincentS
Copy link
Contributor Author

VincentS commented Jun 30, 2016 •
edited
Loading

#92 Reference Issue

@VincentS
Copy link
Contributor Author

How can I check if OpenMP builds with this fix on Travis?

@anttikantee
Copy link
Member

On 22/07/16 13:43, Vincent Schwarzer wrote:

How can I check if OpenMP builds with this fix on Travis?

AFAIR you just enable it in .travis.yml on a branch and either push that
branch or open a PR with your .travis.yml change.

(it would be good to document this sort of thing somewhere, but the hard
things is deciding where to document it)

@anttikantee
Copy link
Member

Looking at the actual change, I don't think it's a good idea to hardcode bash instead of $(shell)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VincentS @anttikantee