atlantis unlock results in misleading error: Failed to delete PR locks

[bschaatsbergen]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.

---

Overview of the Issue

Since v0.26.0 I keep getting "Failed to delete PR locks" when commenting atlantis unlock, and actually the locks are deleted successfully without any issue.

Reproduction Steps

Logs

Environment details

Additional Context

It was introduced here possibly https://github.com/runatlantis/atlantis/pull/3751/files#diff-718a5cf3b673c927e6c880baa4e7a7be3e729fe0a74e6749b89c39448f8ef83cR61

// The locks controller currently has no implementation of Atlantis project names, so this is hardcoded to an empty string.
	projectName := ""

and then calls

removeErr := l.WorkingDir.DeletePlan(lock.Pull.BaseRepo, lock.Pull, lock.Workspace, lock.Project.Path, projectName)

DeletePlan calls GetPlanFilename to get the plan filename (here)

// GetPlanFilename returns the filename (not the path) of the generated tf plan
// given a workspace and project name.
func GetPlanFilename(workspace string, projName string) string {
	if projName == "" {
		return fmt.Sprintf("%s.tfplan", workspace)
	}
	projName = strings.Replace(projName, "/", planfileSlashReplace, -1)
	return fmt.Sprintf("%s-%s.tfplan", projName, workspace)
}

but since 0.26, starting on the PR above, the projName is empty, so the filename will always be %s.tfplan, but in my case it should’ve been %s-%s.tfplan like you show on you plan command

[bschaatsbergen]

I would happily prep a fix for this bug 👍🏼

[jamengual]

please do Bruno, I will be greatly appreciated.

…

On Thu, Oct 19, 2023, 5:39 p.m. Bruno Schaatsbergen < ***@***.***> wrote: I would happily prep a fix for this bug 👍🏼 — Reply to this email directly, view it on GitHub <#3877 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAQ3ERAGQIY2ZFBMMWDBNLDYAHB35AVCNFSM6AAAAAA6IBU6WKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZRHA4TEOJTGI> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[nitrocode]

Duplicate of #3856 which is a duplicate of #3845

[nitrocode]

Yes please put in a PR. I followed the thread in slack. Great sleuthing by Gabriel and hoping for a fix soon!

Only closing to consolidate conversation in original ticket

[X-Guardian]

@bschaatsbergen, please read #3845 (comment) before starting work on a PR.