Changes to testdata and templates don't run CI tests

[glasser]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Overview of the Issue

Changes to testdata and *.tmpl templates do not trigger PR CI test runs, but they can make tests fail.

Reproduction Steps

• Make a PR that only changes *.tmpl templates and *.txt testdata files (but no Go code) such as fix: properly render 🚮 in default templates #4044
• Fail to update enough to make all of the tests pass
• Expect GH Actions CI to tell me if I'm about to break CI on main
• But in fact tests do not run

I think the path filter in test.yml should notice changes to templates and testdata at the very least:

  changes:
    outputs:
      should-run-tests: ${{ steps.changes.outputs.go == 'true' }}
    if: github.event.pull_request.draft == false
    runs-on: ubuntu-22.04
    steps:
      - uses: actions/checkout@v4
      - uses: dorny/paths-filter@v2
        id: changes
        with:
          filters: |
            go:
              - '**.go'
              - 'go.*'
              - '.github/workflows/test.yml'