fix: properly render 🚮 in default templates #4044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that GitHub has changed its Markdown renderer such that an emoji followed by a string of plain text (with no other formatting) followed by a colon at the end of the line renders as plain text instead of as the emoji. Compare the following two lines: * 🚮 To delete all plans and locks for the PR, comment: * 🚮 To **delete** all plans and locks for the PR, comment: While this seems like it is probably a GitHub bug, we can work around it by adding some formatting between the emoji and the end of the line, which matches the bullet point above it anyway.
|
For future reference in case GitHub changes the renderer again:
|
glasser
changed the title
|
/cherry-pick release-0.27 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Dec 13, 2023
It seems that GitHub has changed its Markdown renderer such that an emoji followed by a string of plain text (with no other formatting) followed by a colon at the end of the line renders as plain text instead of as the emoji. Compare the following two lines: * 🚮 To delete all plans and locks for the PR, comment: * 🚮 To **delete** all plans and locks for the PR, comment: While this seems like it is probably a GitHub bug, we can work around it by adding some formatting between the emoji and the end of the line, which matches the bullet point above it anyway.
lukemassa
pushed a commit
that referenced
this pull request
Dec 20, 2023
It seems that GitHub has changed its Markdown renderer such that an emoji followed by a string of plain text (with no other formatting) followed by a colon at the end of the line renders as plain text instead of as the emoji. Compare the following two lines: * 🚮 To delete all plans and locks for the PR, comment: * 🚮 To **delete** all plans and locks for the PR, comment: While this seems like it is probably a GitHub bug, we can work around it by adding some formatting between the emoji and the end of the line, which matches the bullet point above it anyway.
lukemassa
pushed a commit
that referenced
this pull request
Dec 20, 2023
It seems that GitHub has changed its Markdown renderer such that an emoji followed by a string of plain text (with no other formatting) followed by a colon at the end of the line renders as plain text instead of as the emoji. Compare the following two lines: * 🚮 To delete all plans and locks for the PR, comment: * 🚮 To **delete** all plans and locks for the PR, comment: While this seems like it is probably a GitHub bug, we can work around it by adding some formatting between the emoji and the end of the line, which matches the bullet point above it anyway. Co-authored-by: David Glasser <glasser@apollographql.com>
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
It seems that GitHub has changed its Markdown renderer such that an emoji followed by a string of plain text (with no other formatting) followed by a colon at the end of the line renders as plain text instead of as the emoji. Compare the following two lines: * 🚮 To delete all plans and locks for the PR, comment: * 🚮 To **delete** all plans and locks for the PR, comment: While this seems like it is probably a GitHub bug, we can work around it by adding some formatting between the emoji and the end of the line, which matches the bullet point above it anyway.
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
It seems that GitHub has changed its Markdown renderer such that an emoji followed by a string of plain text (with no other formatting) followed by a colon at the end of the line renders as plain text instead of as the emoji. Compare the following two lines: * 🚮 To delete all plans and locks for the PR, comment: * 🚮 To **delete** all plans and locks for the PR, comment: While this seems like it is probably a GitHub bug, we can work around it by adding some formatting between the emoji and the end of the line, which matches the bullet point above it anyway.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
It seems that GitHub has changed its Markdown renderer such that an emoji followed by a string of plain text (with no other formatting) followed by a colon at the end of the line renders as plain text instead of as the emoji. Compare the following three lines:
🚮 To delete all plans and locks for the PR, comment:
🚮 To delete all plans and locks for the PR, comment
🚮 To delete all plans and locks for the PR, comment:
While this seems like it is probably a GitHub bug, we can work around it by adding some formatting between the emoji and the end of the line, which matches the bullet point above it anyway.
why
It's ugly to see spelled-out emoji instead of the emoji.
tests
Just look a few lines up in this message to see the impact.