Commits on Aug 23, 2021

1. Validate base branches in DefaultCommandRunner …

   Fixes runatlantis#1539
   
   The branch matcher feature has been introduced in runatlantis#1383, but the current
   implementation was broken and doesn't work at all (runatlantis#1539).
   
   If my understanding is correct, there are two problems:
   
   (1) The `GlobalCfg` has a default `Repo` instance which always matches
   any repositries and branches. Therefore the branch matcher never be
   functional.
   (2) Validating base branches in
   `DefaultPreWorkflowHooksCommandRunner.RunPreHooks()` implicitly assumed
   that users customize `pre_workflow_hooks`, but the assumption isn't
   always true because it defaults to empty.
   
   For (1), I added a new method `MatchingRepo()` to `GlobalCfg` to check
   `BranchMatches()` for a single `Repo` instance.
   
   For (2), I moved validating branch to
   `DefaultCommandRunner.validateCtxAndComment()`. Since the method has
   already validated meta data of pull request, I think it's suitable place
   to check base branches, but please let me know if there is anywhere more
   suitable.

   

   minamijoyo committed Aug 23, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for 8037de4
   • Browse repository at this point

   Copy the full SHA

   8037de4 View commit details

   Browse the repository at this point in the history