Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitbucket server aka stash #194

Merged
merged 11 commits into from
Jul 25, 2018
Merged

Bitbucket server aka stash #194

merged 11 commits into from
Jul 25, 2018

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Jul 23, 2018

Fixes #190

Todo

  • Support webhook secrets
  • Test
  • Update docs

Note: Triggering plan on pull request updates does not work because Bitbucket Server doesn't send an event when the pull request is updated (although it does send an event when any ref in the repo is updated). I've created #198 to track this.

@codecov
Copy link

codecov bot commented Jul 23, 2018

Codecov Report

Merging #194 into master will decrease coverage by 1.66%.
The diff coverage is 44.08%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #194      +/-   ##
==========================================
- Coverage   71.05%   69.38%   -1.67%     
==========================================
  Files          54       56       +2     
  Lines        2843     3126     +283     
==========================================
+ Hits         2020     2169     +149     
- Misses        701      807     +106     
- Partials      122      150      +28
Impacted Files Coverage Δ
server/events/vcs/proxy.go 0% <0%> (ø) ⬆️
server/events/command_runner.go 68.84% <0%> (-3.76%) ⬇️
server/locks_controller.go 92.3% <0%> (-3.08%) ⬇️
server/events/models/models.go 82.35% <100%> (+25.21%) ⬆️
server/events_controller.go 52.86% <2.98%> (-13.44%) ⬇️
server/events/vcs/bitbucketcloud/client.go 39.21% <30.76%> (ø)
server/events/vcs/bitbucketserver/client.go 38.09% <38.09%> (ø)
server/server.go 62.13% <41.93%> (-1.66%) ⬇️
...r/events/vcs/bitbucketserver/request_validation.go 58.82% <58.82%> (ø)
cmd/server.go 79.02% <64.28%> (-0.4%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9129bb8...08c19ed. Read the comment docs.

@lkysow lkysow force-pushed the bitbucket-server branch 2 times, most recently from d6c4e0f to 74c7b9e Compare July 24, 2018 18:30
@lkysow lkysow merged commit 9e18c8a into master Jul 25, 2018
@lkysow lkysow deleted the bitbucket-server branch July 25, 2018 12:58
meringu pushed a commit to meringu/atlantis that referenced this pull request May 29, 2023
meringu pushed a commit to meringu/atlantis that referenced this pull request May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant