Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require approval from someone other than PR author #202

Merged
merged 1 commit into from
Jul 30, 2018

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Jul 28, 2018

In Bitbucket cloud, the pull request author can approve their own pull
request. Ignore this approval.

Fixes #201

In Bitbucket cloud, the pull request author can approve their own pull
request. Ignore this approval.

Fixes #201
@codecov
Copy link

codecov bot commented Jul 28, 2018

Codecov Report

Merging #202 into master will increase coverage by 0.25%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #202      +/-   ##
==========================================
+ Coverage   69.38%   69.64%   +0.25%     
==========================================
  Files          56       56              
  Lines        3126     3126              
==========================================
+ Hits         2169     2177       +8     
+ Misses        807      796      -11     
- Partials      150      153       +3
Impacted Files Coverage Δ
server/events/vcs/bitbucketcloud/client.go 47.05% <100%> (+7.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc6b4a1...ff85cbe. Read the comment docs.

@lkysow lkysow merged commit c212d0b into master Jul 30, 2018
@lkysow lkysow deleted the bitbucket-approvals branch July 30, 2018 15:59
@teosoft123
Copy link

I think there might be a (debug) flag that allows approvals from the pull requestors. Might help with debugging for small teams.

@lkysow
Copy link
Member Author

lkysow commented Jul 30, 2018

@teosoft123 do you mean that you'd like there to be a debug flag on the Atlantis side to disable requiring approvals?

@teosoft123
Copy link

teosoft123 commented Jul 30, 2018

@lkysow precisely. One can have it both ways. I'd have the flag to enable self-approvals so that default is what most people expect, disable them

@lkysow
Copy link
Member Author

lkysow commented Aug 1, 2018

In that case I'd prefer the teams use an atlantis.yaml file to disable approvals for that specific repo. Also only bitbucket cloud supports self approvals.

meringu pushed a commit to meringu/atlantis that referenced this pull request May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants