fix: Running 'atlantis unlock' on a PR Causes The Whole Working Directory to be Deleted #3751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
X-Guardian
changed the title
GenPage
approved these changes
Sep 11, 2023
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
…tory to be Deleted (runatlantis#3751) * Running 'atlantis unlock' on a PR Causes The Whole Working Directory to be Deleted * Update events controller tests * Fix events controller tests --------- Co-authored-by: PePe Amengual <jose.amengual@gmail.com>
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
…tory to be Deleted (runatlantis#3751) * Running 'atlantis unlock' on a PR Causes The Whole Working Directory to be Deleted * Update events controller tests * Fix events controller tests --------- Co-authored-by: PePe Amengual <jose.amengual@gmail.com>
terakoya76
pushed a commit
to terakoya76/atlantis
that referenced
this pull request
Dec 31, 2024
…tory to be Deleted (runatlantis#3751) * Running 'atlantis unlock' on a PR Causes The Whole Working Directory to be Deleted * Update events controller tests * Fix events controller tests --------- Co-authored-by: PePe Amengual <jose.amengual@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
In the
DeleteLocksByPullfunction, replace thedeleteWorkingDirfunction call withWorkingDir.DeletePlanso that only the plan files are deleted for the lock rather than the whole working directory.Improved logging has also been added to the
events_controller,unlock_command_runneranddelete_lock_command.The additional logging in the
events_controllermodule also exposed issues in theTestPost_GitlabCommentSuccess,TestPost_GithubCommentReaction,TestPost_GilabCommentReactionandTestPost_AzureDevopsPullRequestCommentPassingIgnorestests, which have also been fixed.why
tests
Tested locally