feat: Add logic for project name into lock

[lukemassa]

what

Add logic of project name into locks.

why

I'm actually not totally sure why Project in models didn't have a ProjectName before. Adding this made it so we can, e.g., correctly identify the project plan files that need to be deleted when we run atlantis unlock (See #3845)

This is not a total fix, and instead kicks the can down the road a little bit. Specifically, I do not implement project_finder() to understand about project names, because frankly I'm not totally sure how, so I just assume the project doesn't have a name (i.e. empty string for ProjectName). That said, this is no worse than the current implementation, which implicitly assumes the project doesn't have a name "deeper" in the call stack.

In this sense, in my opinion this PR is a net positive, in that it moves us in the right direction, fixes a particular bug, and (as far as I know) doesn't introduce any regressions.

tests

Confirming the expected behavior change

I configured a workspace with a name projectname, did a plan, then attempted to unlock.
Before:

{"level":"error","ts":"2024-02-05T23:35:23.329-0500","caller":"events/unlock_command_runner.go:62","msg":"failed to delete locks by pull remove /Users/lukemassa/.atlantis/repos/cloud/playground/lmassa-test-atlantis/36/lmassa/lmassa.tfplan: no such file or directory","json":{"repo":"cloud/playground/lmassa-test-atlantis","pull":"36"},"stacktrace":"github.com/runatlantis/atlantis/server/events.(*UnlockCommandRunner).Run\n\t/Users/lukemassa/atlantis/server/events/unlock_command_runner.go:62\ngh.neting.cc/runatlantis/atlantis/server/events.(*DefaultCommandRunner).RunCommentCommand\n\t/Users/lukemassa/atlantis/server/events/command_runner.go:365"}

After:

{"level":"info","ts":"2024-02-05T23:41:15.515-0500","caller":"events/working_dir.go:426","msg":"Deleting plan: /Users/lukemassa/.atlantis/repos/cloud/playground/lmassa-test-atlantis/36/lmassa/projectname-lmassa.tfplan","json":{}}

Confirming no regressions

1. If name is absent, the behavior is as before:

{"level":"info","ts":"2024-02-07T14:39:26.711-0500","caller":"events/working_dir.go:426","msg":"Deleting plan: /Users/lukemassa/.atlantis/repos/cloud/playground/lmassa-test-atlantis/36/lmassa/lmassa.tfplan","json":{}}

2. Whether or not name is present, closing the PR itself retains its previous behavior of blowing away the entire directory (and there is no log line of atlantis even attempting to delete the plan file)

{"level":"info","ts":"2024-02-07T14:44:49.270-0500","caller":"events/working_dir.go:393","msg":"Deleting repo pull directory: /Users/lukemassa/.atlantis/repos/cloud/playground/lmassa-test-atlantis/36","json":{}}

references

Closes: #3845

[lukemassa]

/cherry-pick release-0.27

[GenPage]

/cherry-pick release-0.27