feat: Refine the logging in the Working Dir Package #4294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
X-Guardian
requested review from
GenPage,
lukemassa and
nitrocode
and removed request for
a team
X-Guardian
changed the title
GenPage
previously approved these changes
Feb 29, 2024
|
@GenPage, this PR is ready for re-review. I fixed the failing tests. |
GenPage
approved these changes
Mar 27, 2024
GenPage
added
the
refactoring
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
This PR refines the logging in the Atlantis Working Dir package.
Also changes
%qin the logging strings to'%s'to prevent the double quotes created by%qin the string needing to be escaped in the JSON log output.why
Improve the Atlantis debug logging. Working dir logging entries will now be included in the
--verboseoutput when running Atlantis commands, making trouble shooting easier, as debug logs for a command can be produced without having to run the Atlantis server with the debug log level.tests
Tested locally
references