Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(slack-hooks): updated example for atlantis configuration #4525

Merged
merged 2 commits into from
May 9, 2024
Merged

fix(slack-hooks): updated example for atlantis configuration #4525

merged 2 commits into from
May 9, 2024

Conversation

neilscallywag
Copy link
Contributor

what

  • Added clarity to the documentations that the configuration expects the channel id and not the channel name.

why

  • Current documentation is ambiguous with regards to weather the configuration file expects channel name or channel id.

tests

Nil

references

Nil

@neilscallywag neilscallywag requested review from a team as code owners May 9, 2024 04:19
@neilscallywag neilscallywag requested review from jamengual, lukemassa and X-Guardian and removed request for a team May 9, 2024 04:19
@github-actions github-actions bot added the docs Documentation label May 9, 2024
@neilscallywag neilscallywag requested a review from chenrui333 May 9, 2024 06:09
chenrui333
chenrui333 approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the catch.

@chenrui333 chenrui333 enabled auto-merge (squash) May 9, 2024 14:52
@chenrui333 chenrui333 merged commit c4a2a2c into runatlantis:main May 9, 2024
23 checks passed
@BrewTestBot BrewTestBot mentioned this pull request May 22, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenrui333 chenrui333 chenrui333 approved these changes

@jamengual jamengual Awaiting requested review from jamengual jamengual is a code owner automatically assigned from runatlantis/maintainers

@lukemassa lukemassa Awaiting requested review from lukemassa lukemassa is a code owner automatically assigned from runatlantis/core-contributors

@X-Guardian X-Guardian Awaiting requested review from X-Guardian X-Guardian is a code owner automatically assigned from runatlantis/core-contributors

Assignees
No one assigned
Labels
docs Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neilscallywag @chenrui333