Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Add link to Survey in top bar #4574

Merged
merged 6 commits into from
May 18, 2024

Conversation

jippi
Copy link
Contributor

@jippi jippi commented May 17, 2024

In case folks dismiss the survey top bar, its still easily accessible.

I've had folks at $DayJob ask about the survey link twice today, because they dismissed the banner out of habit (looks like a banner/cookie content block) without reading it first.

I personally dismissed it at work without thinking because I needed to go to the docs fix an issue for a engineer, and the bar was visually distracting and looked like marketing - didn't even think about it, just removed it like a cookie consent banner by pure habit

So been needing to go to the source code 3 times today to dig up the banner URL because of "click to dismiss"-habits, so thought it was likely other folks had similar experience.

Preview: https://deploy-preview-4574--runatlantis.netlify.app/

@jippi jippi marked this pull request as ready for review May 17, 2024 22:47
@jippi jippi requested review from a team as code owners May 17, 2024 22:47
@jippi jippi requested review from jamengual, lukemassa and X-Guardian and removed request for a team May 17, 2024 22:47
@chenrui333
Copy link
Member

image

Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @jippi! (Love that 📢 emoji 😆 )

@chenrui333 chenrui333 merged commit f3a7376 into runatlantis:main May 18, 2024
24 checks passed
@jippi jippi deleted the jippi-patch-1 branch May 18, 2024 21:37
terakoya76 pushed a commit to terakoya76/atlantis that referenced this pull request Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants