Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix docker base image sha #4599

Merged
merged 1 commit into from
May 23, 2024
Merged

fix: fix docker base image sha #4599

merged 1 commit into from
May 23, 2024

Conversation

chenrui333
Copy link
Member

@chenrui333 chenrui333 commented May 23, 2024 •
edited
Loading

fixes #4598

$ regctl image digest golang:1.22.3
sha256:f43c6f049f04cbbaeb28f0aad3eea15274a7d0a7899a617d0037aec48d7ab010

$ regctl image digest golang:1.22.3-alpine
sha256:b8ded51bad03238f67994d0a6b88680609b392db04312f60c23358cc878d4902

$ regctl image digest debian:12.5-slim
sha256:804194b909ef23fb995d9412c9378fb3505fe2427b70f3cc425339e48a828fca

$ regctl image digest alpine:3.19.1
sha256:c5b1261d6d3e43071626931fc004f70149baeba2c8ec672bd4f27761f8e1ad6b

relates to #4456

@chenrui333
fix: fix docker base image sha
64ee696 
Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333 chenrui333 requested review from a team as code owners May 23, 2024 19:07
@chenrui333 chenrui333 requested review from GenPage, lukemassa and X-Guardian and removed request for a team May 23, 2024 19:07
@github-actions github-actions bot added build Relating to how we build Atlantis size/xs labels May 23, 2024
@chenrui333 chenrui333 requested review from jamengual and nitrocode May 23, 2024 19:11
@chenrui333 chenrui333 added the bug Something isn't working label May 23, 2024
@chenrui333 chenrui333 merged commit 1453377 into main May 23, 2024
28 checks passed
@chenrui333 chenrui333 deleted the fix-base-image-sha branch May 23, 2024 19:28
@chenrui333
Copy link
Member Author

/cherry-pick release-0.28

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request May 23, 2024
@chenrui333
fix: fix docker base image sha (#4599)
43761d7 
Signed-off-by: Rui Chen <rui@chenrui.dev>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request May 23, 2024
Merged
chenrui333 added a commit that referenced this pull request May 23, 2024
@gcp-cherry-pick-bot @chenrui333
fix: fix docker base image sha (cherry-pick #4599) (release-0.28) (#4600
a5fdebc 
)

Signed-off-by: Rui Chen <rui@chenrui.dev>
Co-authored-by: Rui Chen <rui@chenrui.dev>
@jippi
Copy link
Contributor

jippi commented May 23, 2024 •
edited
Loading

Nice find everyone! 🎉 looks like @jamengual was right on the money!

I wonder if a GOSS test would have caught it, by simply running the binary inside the container? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukemassa lukemassa lukemassa approved these changes

@jamengual jamengual jamengual approved these changes

@GenPage GenPage Awaiting requested review from GenPage GenPage is a code owner automatically assigned from runatlantis/maintainers

@X-Guardian X-Guardian Awaiting requested review from X-Guardian X-Guardian is a code owner automatically assigned from runatlantis/core-contributors

@nitrocode nitrocode Awaiting requested review from nitrocode

Assignees
No one assigned
Labels
bug Something isn't working build Relating to how we build Atlantis size/xs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v0.28.0 Docker image for ARM64 architecture contains wrong binary format
4 participants
@chenrui333 @jippi @jamengual @lukemassa