fix: link latest commit to the correct pipeline #4865
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR runatlantis#4785 was a partial fix, as it might link a commit to the wrong pipeline when GitLab is slow to update the HeadPipeline. This patch ensures the latest commit is always linked to the correct pipeline by querying the pipeline associated with the commit's ref, instead of relying on HeadPipeline. Tested in our environment and it looks good so far. Signed-off-by: Raul Gutierrez Segales <rsegales@nvidia.com>
rgs1
requested review from
jamengual,
nitrocode and
X-Guardian
and removed request for
a team
rgs1
changed the title
rgs1
changed the title
|
Superseded by #5033 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #4785 was a partial fix, as it might link a commit to the wrong pipeline when GitLab is slow to update the HeadPipeline.
This patch ensures the latest commit is always linked to the correct pipeline by querying the pipeline associated with the commit's ref, instead of relying on HeadPipeline.
Tested in our environment and it looks good so far.
Signed-off-by: Raul Gutierrez Segales rsegales@nvidia.com