Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update error messages when working with OpenTofu #4996

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

meringu
Copy link
Contributor

@meringu meringu commented Oct 10, 2024

what

Small follow up to #4499. When working with OpenTofu, Atlantis will talk about terraform in some of the error messages. This is confusing when using OpenTofu. For example, when setting ATLANTIS_DEFAULT_TF_VERSION=1.5.7 to get the latest version of Terraform published under the MPL, then migrating to tofu by setting ATLANTIS_TF_DISTRIBUTION=opentofu you will get this confusing message:

error downloading terraform version 1.5.7: No such version: 1.5.7

This change will now output:

error downloading tofu version 1.5.7: No such version: 1.5.7

why

Better UX for error cases

tests

Just an error message change, so haven't done any detailed integration testing for this.

references

Follow up to #4499

@meringu meringu requested review from a team as code owners October 10, 2024 04:31
@meringu meringu requested review from jamengual, nitrocode and X-Guardian and removed request for a team October 10, 2024 04:31
@github-actions github-actions bot added the go Pull requests that update Go code label Oct 10, 2024
@jamengual jamengual changed the title Update error messages when working with OpenTofu fix: Update error messages when working with OpenTofu Oct 10, 2024
Copy link
Contributor

@jamengual jamengual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meringu Thanks again for the contribution

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 10, 2024
@jamengual jamengual merged commit 110ef94 into runatlantis:main Oct 10, 2024
32 of 34 checks passed
@meringu meringu deleted the opentofu-error-msg branch October 10, 2024 05:35
a1k0u pushed a commit to a1k0u/atlantis that referenced this pull request Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code lgtm This PR has been approved by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants