Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate workspace the same way as Terraform. #78

Merged
merged 1 commit into from
Mar 20, 2018
Merged

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Mar 20, 2018

Saw in the TF code how they were validating workspace names
and decided to do the same. '..' is actually a valid TF workspace but we
don't support that.

Saw in the TF code how they were validating workspace names
and decided to do the same. '..' is actually a valid TF workspace but we
don't support that.
@codecov
Copy link

codecov bot commented Mar 20, 2018

Codecov Report

Merging #78 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #78   +/-   ##
=======================================
  Coverage   64.09%   64.09%           
=======================================
  Files          40       40           
  Lines        1916     1916           
=======================================
  Hits         1228     1228           
  Misses        626      626           
  Partials       62       62
Impacted Files Coverage Δ
server/events/comment_parser.go 95.29% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7c582c...85ab747. Read the comment docs.

@lkysow lkysow merged commit 9ce2704 into master Mar 20, 2018
@lkysow lkysow deleted the workspace-validation branch March 20, 2018 19:55
meringu pushed a commit to meringu/atlantis that referenced this pull request May 29, 2023
Delete dynamodb locking code since Atlantis only works with disk righ…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant