Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use bigger logo on the web pages #783

Merged
merged 3 commits into from
Oct 4, 2019
Merged

Use bigger logo on the web pages #783

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e8d1e6
Use bigger logo on the web pages
Nuru Sep 20, 2019
a3d90d1
Update go.mod
lkysow Oct 4, 2019
08127b2
Update go.sum
lkysow Oct 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,3 +65,5 @@ require (
gopkg.in/yaml.v2 v2.2.2
gotest.tools v2.2.0+incompatible // indirect
)

replace git.apache.org/thrift.git => github.com/apache/thrift v0.0.0-20180902110319-2566ecd5d999
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was required to get atlantis to build on my system. I am not a go developer and do not know how the go module system works, so I cannot give you a definitive explanation. All I can say is that those lines were added by my IDE, apparently because go.sum refers to git.apache.org/thrift.git which no longer exists, and the content has been moved to https://github.com/apache/thrift

My brief investigation suggested that this was not a direct requirement of atlantis but rather a requirement of a module atlantis depends on, so I was not able to fix it by directly changing the reference in go.sum.

It is irrelevant to the changes that implement the goals of the PR, but I left it in for the atlantis team to see and make a proper fix.

1 change: 1 addition & 0 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ github.com/alecthomas/units v0.0.0-20151022065526-2efee857e7cf/go.mod h1:ybxpYRF
github.com/anmitsu/go-shlex v0.0.0-20161002113705-648efa622239/go.mod h1:2FmKhYUyUczH0OGQWaF5ceTx0UBShxjsH6f8oGKYe2c=
github.com/aokoli/goutils v1.0.1 h1:7fpzNGoJ3VA8qcrm++XEE1QUe0mIwNeLa02Nwq7RDkg=
github.com/aokoli/goutils v1.0.1/go.mod h1:SijmP0QR8LtwsmDs8Yii5Z/S4trXFGFC2oO5g9DP+DQ=
github.com/apache/thrift v0.0.0-20180902110319-2566ecd5d999/go.mod h1:cp2SuWMxlEZw2r+iP2GNCdIi4C1qmUzdZFSVb+bacwQ=
github.com/asaskevich/govalidator v0.0.0-20190424111038-f61b66f89f4a h1:idn718Q4B6AGu/h5Sxe66HYVdqdGu2l9Iebqhi/AEoA=
github.com/asaskevich/govalidator v0.0.0-20190424111038-f61b66f89f4a/go.mod h1:lB+ZfQJz7igIIfQNfa7Ml4HSf2uFQQRzpGGRXenZAgY=
github.com/aws/aws-sdk-go v1.15.78/go.mod h1:E3/ieXAlvM0XWO57iftYVDLLvQ824smPP3ATZkfNZeM=
Expand Down
14 changes: 7 additions & 7 deletions server/static/bindata_assetfs.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 7 additions & 3 deletions server/static/css/custom.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,14 @@
.container {
max-width: 1000px; }
.header {
margin-top: 6rem;
margin-top: 2.5vh;
text-align: center; }
img.hero {
height: 20vh;
max-height: 240px;
width: auto;
max-width: 241px
}
.heading-font-size {
font-size: 1.2rem;
color: #999;
Expand Down Expand Up @@ -57,8 +63,6 @@ tbody {

/* Larger than phone */
@media (min-width: 550px) {
.header {
margin-top: 10rem; }
.value-props {
margin-top: 9rem;
margin-bottom: 7rem; }
Expand Down
Loading