refactor: convert "play sound at position" to message

src/main/java/org/runejs/client/message/handler/rs435/RS435HandlerRegistry.java

@@ -15,6 +15,7 @@
 import org.runejs.client.message.handler.rs435.chat.*;
 import org.runejs.client.message.handler.rs435.console.*;
 import org.runejs.client.message.handler.rs435.misc.*;
+import org.runejs.client.message.handler.rs435.world.*;
 import org.runejs.client.message.inbound.camera.*;
 import org.runejs.client.message.inbound.chat.*;
 import org.runejs.client.message.handler.rs435.audio.PlayQuickSongMessageHandler;
@@ -34,6 +35,7 @@
 import org.runejs.client.message.inbound.widget.model.*;
 import org.runejs.client.message.inbound.widget.text.*;
 import org.runejs.client.message.inbound.widget.visibility.*;
+import org.runejs.client.message.inbound.world.*;
 
 /**
  * A {@link MessageHandlerRegistry} for the RS revision 435 client.
@@ -124,5 +126,8 @@ public RS435HandlerRegistry() {
         register(LoadStandardRegionInboundMessage.class, new LoadStandardRegionMessageHandler());
         register(LoadConstructedRegionInboundMessage.class, new LoadConstructedRegionMessageHandler());
         register(UpdateReferencePositionInboundMessage.class, new UpdateReferencePositionMessageHandler());
+
+        // world
+        register(PlaySoundAtPositionInboundMessage.class, new PlaySoundAtPositionMessageHandler());
     }
 }

src/main/java/org/runejs/client/message/handler/rs435/world/PlaySoundAtPositionMessageHandler.java

@@ -0,0 +1,23 @@
+package org.runejs.client.message.handler.rs435.world;
+
+import org.runejs.client.MovedStatics;
+import org.runejs.client.cache.def.OverlayDefinition;
+import org.runejs.client.media.renderable.actor.Player;
+import org.runejs.client.message.handler.MessageHandler;
+import org.runejs.client.message.inbound.world.PlaySoundAtPositionInboundMessage;
+import org.runejs.client.sound.SoundSystem;
+
+public class PlaySoundAtPositionMessageHandler implements MessageHandler<PlaySoundAtPositionInboundMessage> {
+    @Override
+    public void handle(PlaySoundAtPositionInboundMessage message) {
+        int localY = message.y + OverlayDefinition.placementY;
+        int localX = message.x + MovedStatics.placementX;
+
+        if (localX >= 0 && localY >= 0 && localX < 104 && localY < 104) {
+            int i_26_ = 1 + message.radius;
+            if (Player.localPlayer.pathY[0] >= localX - i_26_ && Player.localPlayer.pathY[0] <= localX + i_26_ && localY - i_26_ <= Player.localPlayer.pathX[0] && localY + i_26_ >= Player.localPlayer.pathX[0]) {
+                SoundSystem.play(message.soundId, message.volume, message.delay, message.radius + (localY << 8) + (localX << 16));
+            }
+        }
+    }
+}

src/main/java/org/runejs/client/message/inbound/world/PlaySoundAtPositionInboundMessage.java

@@ -0,0 +1,26 @@
+package org.runejs.client.message.inbound.world;
+
+import org.runejs.client.message.InboundMessage;
+
+public class PlaySoundAtPositionInboundMessage implements InboundMessage {
+    public final int x;
+
+    public final int y;
+
+    public final int soundId;
+
+    public final int radius;
+
+    public final int volume;
+
+    public final int delay;
+
+    public PlaySoundAtPositionInboundMessage(int x, int y, int soundId, int radius, int volume, int delay) {
+        this.x = x;
+        this.y = y;
+        this.soundId = soundId;
+        this.radius = radius;
+        this.volume = volume;
+        this.delay = delay;
+    }
+}

src/main/java/org/runejs/client/net/IncomingPackets.java

@@ -128,7 +128,7 @@ public static boolean parseIncomingPackets() {
                 return true;
             }
             // object/ground item update packets?
-            if(opcode == PacketType.PLAY_SOUND_AT_POSITION.getOpcode() || opcode == PacketType.UPDATE_GROUND_ITEM_AMOUNT.getOpcode() || opcode == PacketType.TRANSFORM_PLAYER_TO_OBJECT.getOpcode() || opcode == PacketType.ADD_GROUND_ITEM_EXCLUDE_SOME_PLAYER.getOpcode() || opcode == PacketType.CREATE_STATIONARY_GFX.getOpcode() || opcode == PacketType.CREATE_PROJECTILE.getOpcode() || opcode == PacketType.REMOVE_GROUND_ITEM.getOpcode() || opcode == PacketType.ADD_GROUND_ITEM.getOpcode() || opcode == PacketType.ROTATE_ANIMATE_OBJECT.getOpcode() || opcode == PacketType.REMOVE_OBJECT.getOpcode() || opcode == PacketType.SPAWN_OBJECT.getOpcode()) {
+            if(opcode == PacketType.UPDATE_GROUND_ITEM_AMOUNT.getOpcode() || opcode == PacketType.TRANSFORM_PLAYER_TO_OBJECT.getOpcode() || opcode == PacketType.ADD_GROUND_ITEM_EXCLUDE_SOME_PLAYER.getOpcode() || opcode == PacketType.CREATE_STATIONARY_GFX.getOpcode() || opcode == PacketType.CREATE_PROJECTILE.getOpcode() || opcode == PacketType.REMOVE_GROUND_ITEM.getOpcode() || opcode == PacketType.ADD_GROUND_ITEM.getOpcode() || opcode == PacketType.ROTATE_ANIMATE_OBJECT.getOpcode() || opcode == PacketType.REMOVE_OBJECT.getOpcode() || opcode == PacketType.SPAWN_OBJECT.getOpcode()) {
                 parseMapIncomingPacket();
                 opcode = -1;
                 return true;

src/main/java/org/runejs/client/net/codec/runejs435/RuneJS435PacketCodec.java

@@ -27,6 +27,7 @@
 import org.runejs.client.net.codec.runejs435.decoder.widget.model.*;
 import org.runejs.client.net.codec.runejs435.decoder.widget.text.*;
 import org.runejs.client.net.codec.runejs435.decoder.widget.visibility.*;
+import org.runejs.client.net.codec.runejs435.decoder.world.*;
 import org.runejs.client.net.codec.runejs435.encoder.chat.*;
 import org.runejs.client.net.codec.runejs435.encoder.console.*;
 import org.runejs.client.net.codec.runejs435.encoder.examine.*;
@@ -185,5 +186,8 @@ private void registerDecoders() {
         register(PacketType.CUTSCENE_CAMERA_MOVE_TO.getOpcode(), new CutsceneCameraMoveToMessageDecoder());
         register(PacketType.CLOSE_CUTSCENE.getOpcode(), new CutsceneExitMessageDecoder());
         register(PacketType.SHAKE_CAMERA.getOpcode(), new ShakeCameraMessageDecoder());
+
+        // world
+        register(PacketType.PLAY_SOUND_AT_POSITION.getOpcode(), new PlaySoundAtPositionMessageDecoder());
     }
 }

src/main/java/org/runejs/client/net/codec/runejs435/decoder/world/PlaySoundAtPositionMessageDecoder.java

@@ -0,0 +1,22 @@
+package org.runejs.client.net.codec.runejs435.decoder.world;
+
+import org.runejs.client.message.inbound.world.PlaySoundAtPositionInboundMessage;
+import org.runejs.client.net.PacketBuffer;
+import org.runejs.client.net.codec.MessageDecoder;
+
+public class PlaySoundAtPositionMessageDecoder implements MessageDecoder<PlaySoundAtPositionInboundMessage> {
+    @Override
+    public PlaySoundAtPositionInboundMessage decode(PacketBuffer buffer) {
+        int offset = buffer.getUnsignedByte();
+        int y = (offset & 0x7);
+        int x = (0x7 & offset >> 4);
+        int soundId = buffer.getUnsignedShortBE();
+
+        int soundData = buffer.getUnsignedByte();
+        int radius = soundData >> 4 & 0xf;
+        int volume = 0x7 & soundData;
+        int delay = buffer.getUnsignedByte();
+
+        return new PlaySoundAtPositionInboundMessage(x, y, soundId, radius, volume, delay);
+    }
+}