Fixing packet issues!

runejs · Jun 26, 2020 · ecadcd2 · ecadcd2
1 parent 6cd3910
commit ecadcd2
Show file tree

Hide file tree

Showing 3 changed files with 36 additions and 12 deletions.
diff --git a/src/net/data-parser/inbound-packet-data-parser.ts b/src/net/data-parser/inbound-packet-data-parser.ts
@@ -41,12 +41,10 @@ export class InboundPacketDataParser extends DataParser {
             this.activePacketId = this.activeBuffer.get('BYTE', 'UNSIGNED');
             this.activePacketId = (this.activePacketId - inCipher.rand()) & 0xff;
             const incomingPacket = incomingPackets.get(this.activePacketId);
-            if(!incomingPacket) {
-                // throw new Error(`Unknown packet ${this.activePacketId} received - aborting session.`);
-                logger.warn(`Unknown packet ${this.activePacketId} received.`);
-                this.activePacketSize = 0;
-            } else {
+            if(incomingPacket) {
                 this.activePacketSize = incomingPacket.size;
+            } else {
+                this.activePacketSize = -3;
             }
         }
 

diff --git a/src/net/inbound-packets.ts b/src/net/inbound-packets.ts
@@ -3,8 +3,6 @@ import { logger } from '@runejs/logger';
 import { getFiles } from '../util/files';
 import { ByteBuffer } from '@runejs/byte-buffer';
 
-const ignore = [ 234, 160, 216, 13, 58 /* camera move */ ];
-
 interface InboundPacket {
     opcode: number;
     size: number;
@@ -32,11 +30,6 @@ export async function loadPackets(): Promise<Map<number, InboundPacket>> {
 }
 
 export function handlePacket(player: Player, packetId: number, packetSize: number, buffer: ByteBuffer): void {
-    if(ignore.indexOf(packetId) !== -1) {
-        return;
-    }
-
-    // const packetFunction = packets[packetId];
     const incomingPacket = incomingPackets.get(packetId);
 
     if(!incomingPacket) {

diff --git a/src/net/inbound-packets/junk-packets.js b/src/net/inbound-packets/junk-packets.js
@@ -0,0 +1,33 @@
+const handler = () => {};
+
+export default [
+    {
+        opcode: 234,
+        size: 4,
+        handler: handler
+    }, {
+        opcode: 160,
+        size: 1,
+        handler: handler
+    }, {
+        opcode: 216,
+        size: 0,
+        handler: handler
+    }, {
+        opcode: 13,
+        size: 0,
+        handler: handler
+    }, {
+        opcode: 58, // camera move
+        size: 4,
+        handler: handler
+    }, {
+        opcode: 121,
+        size: 4,
+        handler: handler
+    }, {
+        opcode: 178,
+        size: 0,
+        handler: handler
+    }
+];