Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduces --debugger-command flag to krun #3687

Merged
merged 4 commits into from
Oct 4, 2023

Conversation

Robertorosmaninho
Copy link
Collaborator

This PR reflects a new modification on the llvm-krun from the llvm-backend.

This new flag enables the user to pass a file with debug commands to its debugger and run them in a non-interactive mode!

This new flag also allows testing the debugger on our current CI.

@Robertorosmaninho Robertorosmaninho self-assigned this Oct 3, 2023
@rv-jenkins rv-jenkins changed the base branch from master to develop October 3, 2023 17:14
@Robertorosmaninho
Copy link
Collaborator Author

Robertorosmaninho commented Oct 3, 2023

This is a follow-up to llvm-backend#851 and llvm-backend#840

Copy link
Contributor

@radumereuta radumereuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but should we merge the backend stuff first and then add a test to this PR?

@Robertorosmaninho
Copy link
Collaborator Author

lgtm, but should we merge the backend stuff first and then add a test to this PR?

Fortunately, no! They're independent!

@rv-jenkins rv-jenkins merged commit 3e7fdeb into develop Oct 4, 2023
8 checks passed
@rv-jenkins rv-jenkins deleted the new-debugger-flag-in-krun branch October 4, 2023 18:03
@Baltoli Baltoli mentioned this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants