This repository has been archived by the owner on Mar 28, 2022. It is now read-only.
Add JS HTTP->HTTPS redirect #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've temporarily enabled RtD builds on this branch to test. You can see this change in action by visiting: |
agermanidis
approved these changes
Apr 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read the docs does not currently support HTTP -> HTTPS redirects for custom domains (CNAME), but they are actively working on it: readthedocs/readthedocs.org#4641
Until those changes are merged we'll have to handle the redirection for the docs ourselves. This is a quick and dirty JS redirect that keeps us from having to host any server-side things ourselves. This can be a temporary solution until proper 302 redirects are implemented in RtD.