Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically create missing parent directories in _Z_DATA path #211

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Automatically create missing parent directories in _Z_DATA path #211

wants to merge 1 commit into from

Conversation

silenc3r
Copy link
Contributor

When parent directories of _Z_DATA don't exist we should automatically create them.

@ericbn
Copy link
Contributor

ericbn commented Nov 12, 2017

Could also touch the file if it does not exist. This would remove the need for changes like 78f0d97 and tests like

# no file yet
[ -f "$datafile" ] || return

dmd
dmd reviewed Oct 24, 2019
View reviewed changes
Copy link

@dmd dmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should be doing this; I believe it's more likely that the path is wrong than it's right but missing, and we should just fail correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmd dmd dmd left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@silenc3r @ericbn @dmd