-
-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hacker news site added #467
Conversation
* Updated PR for LearnWeb3-DAo * removed duplicate description
* added * cssadded * updatedyoutubesubcategory * change-category * webdevelopmentupdated * updated * updated * codewithharryremoved * updateddescription * updated-description * updateddescription * updated * Update web-development.json * description updated * codewithharry-updated * online-tutorials-added * designcourse-added * description changes * ionicons-added * description-changes * description-changes * typed.js-added * added-curly-bracket * revert-changes * updated * filename-changed * description-added * added * freepik-website-added * design-vault-added * removed-design-vault * design-vault-added * Update design-inspirations.json * screenlane-added * sequence-changes * install-uuid * pageflows-added * put-curly-bracket-on-line-149 * pageflow-added * updated * mobbin-added * page-flows-description-updated * space-removed * one-screenlane-link-removed * saasinterface-added * updated
* Added resources for (Tensorflow for deep learning) * Modified database/youtube/machine-learning.json * Added 2 new links for machine-learning under youtube, Added new section 'react js' under frontend, Added a new section 'e-book' under resources
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@TreciaKS pls review my PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Stroller15 it seems you modified over 11 files just to add one site URL to the PR. Why is that? I believe this is the reason your PR is resulting in this error:https://github.com/orgs/community/discussions/25706. Otherwise the Hacker News object added looks great to me. You'll have to wait for the approval of your PR.
@CBID2 May you suggest something? |
"description": "The smarter way to research user interface flows, screen, and email best practices and get unstuck is by learning from proven products.", | ||
"url": "https://pageflows.com/", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"description": "The smarter way to research user interface flows, screen, and email best practices and get unstuck is by learning from proven products.", | |
"url": "https://pageflows.com/", | |
"description": "The smarter way to research user interface flows, screen, email best practices, and getting unstuck is by learning from proven products.", | |
"url": "https://pageflows.com/", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Stroller15! 😄 The Hacker News addition looks pretty good. In regards to the other sources, I just added a suggestion to improve one of the descriptions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Stroller15 I just realised that the changes you've made here you've also made in this PR for issue #467
I feel this would cause conflcts. @CBID2 What do you think about this? (Forgive me for being on a pinging spree this evening for you 😓 )
I don'
According to this, this seems to be more associated with the GitHub Actions. |
Ohh I see, thanks for the link. I read through it. I've learned something 👍 |
Great! 👍🏾 Keep me and @rupali-codes posted! 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the ONLY files you've made changes in :)
Hey, could you open a fresh PR containing the only changes you have made directly to MAIN branch? |
|
Changes proposed
hacker news site added
solved issue #455