rewrite function to compare two list-containing tibbles #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New function is called `expect_equal_tbl` (rather than `expect_equal_listy_tbl`, as previously). One of my tests failed when using the release-pending dplyr=1.0 (and similarly updated rlang, vctrs): the earlier versions of dplyr (etc) allowed attribute mismatches between list-containing tbls but the new dplyr don't (when using tidyr::unnest and then comparing dataframes). The test has been rewritten based on one of my stack overflow posts: https://stackoverflow.com/a/59947803/1845650 ... and no longer needs tidyr I have added a `expect_equivalent_tbl` function too, this allows attribute mismatches when comparing two list-containing tbls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New function is called
expect_equal_tbl(rather thanexpect_equal_listy_tbl, as previously).One of my tests failed when using the release-pending dplyr=1.0 (and
similarly updated rlang, vctrs): the earlier versions of dplyr (etc)
allowed attribute mismatches between list-containing tbls but the new
dplyr don't (when using tidyr::unnest and then comparing dataframes).
The test has been rewritten based on one of my stack overflow posts:
https://stackoverflow.com/a/59947803/1845650
... and no longer needs tidyr
I have added a
expect_equivalent_tblfunction too, this allowsattribute mismatches when comparing two list-containing tbls.