clean macros with vis identifier #865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
finally merged, thank you for this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This (hopefuly) closes #838. That issue is only about named! macro, but I also fixed the same issue in named_attr! and named_args! (by the way, 2 last variants in named_args! didn't support pub(crate)). I didn't touch macros in methods.rs as they are marked as deprecated.
I updated documentation a little bit to run doc-tests on different forms of named! and named_args! instead of just ignoring. Also I compiled and ran test in 2 crates that uses nom 4: der_parser and rusticata-macros. They work fine.
As a drawback - minimal rustc version grows up to 1.30, which makes pipeline jobs with rustc 1.24 fail. But I guess I could rebase this PR after the minimal rustc version for nom would be updated.